-
Notifications
You must be signed in to change notification settings - Fork 605
Fixed macro usage warning of using known items. #8125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c15b00e
to
c705607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-semantic/src/resolve/mod.rs
line 1697 at r1 (raw file):
} // If an item with this name is found inside the current module, use the current module.
Remove this blank line, and consider changing this doc- make it shorter or perhaps move it to the function doc.
c705607
to
15f9e72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dean-starkware)
crates/cairo-lang-semantic/src/resolve/mod.rs
line 1697 at r1 (raw file):
Previously, dean-starkware wrote…
Remove this blank line, and consider changing this doc- make it shorter or perhaps move it to the function doc.
this was a left over from an AI change and deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
15f9e72
to
2334baf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @dean-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
This is now mapped to an error when should not be found, and additionally removes cases before where previously items were mistakingly found.
2334baf
to
7b6fcf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
No description provided.