Skip to content

Fixed macro usage warning of using known items. #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 7, 2025

No description provided.

@orizi orizi requested a review from dean-starkware August 7, 2025 03:54
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/fix-warning branch from c15b00e to c705607 Compare August 7, 2025 06:31
Copy link
Collaborator

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-semantic/src/resolve/mod.rs line 1697 at r1 (raw file):

        }
        // If an item with this name is found inside the current module, use the current module.

Remove this blank line, and consider changing this doc- make it shorter or perhaps move it to the function doc.

@orizi orizi force-pushed the orizi/fix-warning branch from c705607 to 15f9e72 Compare August 7, 2025 08:48
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dean-starkware)


crates/cairo-lang-semantic/src/resolve/mod.rs line 1697 at r1 (raw file):

Previously, dean-starkware wrote…

Remove this blank line, and consider changing this doc- make it shorter or perhaps move it to the function doc.

this was a left over from an AI change and deleted.

Copy link
Collaborator

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the orizi/added-test branch from c654393 to b9d43d4 Compare August 7, 2025 11:05
@orizi orizi force-pushed the orizi/fix-warning branch from 15f9e72 to 2334baf Compare August 7, 2025 11:33
@orizi orizi changed the base branch from orizi/added-test to main August 7, 2025 11:33
@orizi orizi enabled auto-merge August 7, 2025 11:33
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @dean-starkware)

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

This is now mapped to an error when should not be found, and
additionally removes cases before where previously items were mistakingly found.
@orizi orizi force-pushed the orizi/fix-warning branch from 2334baf to 7b6fcf6 Compare August 7, 2025 11:35
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit 944f54b Aug 7, 2025
49 checks passed
@orizi orizi deleted the orizi/fix-warning branch August 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants