apollo_propeller: widen ShardIndex from u32 to u64#12878
apollo_propeller: widen ShardIndex from u32 to u64#12878sirandreww-starkware merged 2 commits intomainfrom
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7a7522f to
d94e4d6
Compare
359ce1f to
bad7a71
Compare
d94e4d6 to
317d66f
Compare
317d66f to
1f1bd66
Compare
bad7a71 to
25ed97a
Compare
25ed97a to
f337800
Compare
93e338f to
fb2307d
Compare
f337800 to
a054a16
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).
a054a16 to
addb197
Compare
fb2307d to
8d224ab
Compare
addb197 to
bfddfc0
Compare
8d224ab to
2f231bb
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).
|
Artifacts upload workflows: |
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 7 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Note
Medium Risk
Changes a core identifier type used in shard creation/validation and protobuf serialization, which can impact wire compatibility and any downstream code assuming
u32indices. Main risk is subtle conversion/compatibility issues when interacting with older peers or stored data.Overview
Widens
ShardIndexfromu32tou64acrossapollo_propeller, removing the prior narrowing conversions during shard creation and updating all call sites and tests accordingly.Updates
PropellerUnitprotobuf conversions to treatindexas au64end-to-end (dropping the previousu32range-check/convert step) and adjusts Merkle-proof and reconstruction paths to convert fromu64tousizewhere needed.Written by Cursor Bugbot for commit bfddfc0. This will update automatically on new commits. Configure here.