Skip to content

apollo_propeller: widen ShardIndex from u32 to u64#12878

Merged
sirandreww-starkware merged 2 commits intomainfrom
02-25-apollo_propeller_widen_shardindex_from_u32_to_u64
Mar 21, 2026
Merged

apollo_propeller: widen ShardIndex from u32 to u64#12878
sirandreww-starkware merged 2 commits intomainfrom
02-25-apollo_propeller_widen_shardindex_from_u32_to_u64

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Feb 26, 2026

Note

Medium Risk
Changes a core identifier type used in shard creation/validation and protobuf serialization, which can impact wire compatibility and any downstream code assuming u32 indices. Main risk is subtle conversion/compatibility issues when interacting with older peers or stored data.

Overview
Widens ShardIndex from u32 to u64 across apollo_propeller, removing the prior narrowing conversions during shard creation and updating all call sites and tests accordingly.

Updates PropellerUnit protobuf conversions to treat index as a u64 end-to-end (dropping the previous u32 range-check/convert step) and adjusts Merkle-proof and reconstruction paths to convert from u64 to usize where needed.

Written by Cursor Bugbot for commit bfddfc0. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@sirandreww-starkware sirandreww-starkware removed the request for review from noamsp-starkware February 26, 2026 08:54
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review February 26, 2026 08:54
@sirandreww-starkware sirandreww-starkware force-pushed the 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test branch from 7a7522f to d94e4d6 Compare February 26, 2026 10:04
@sirandreww-starkware sirandreww-starkware force-pushed the 02-25-apollo_propeller_widen_shardindex_from_u32_to_u64 branch 2 times, most recently from 359ce1f to bad7a71 Compare February 26, 2026 14:42
@sirandreww-starkware sirandreww-starkware force-pushed the 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test branch from d94e4d6 to 317d66f Compare February 26, 2026 14:42
@sirandreww-starkware sirandreww-starkware changed the base branch from 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test to graphite-base/12878 March 5, 2026 07:33
@sirandreww-starkware sirandreww-starkware force-pushed the 02-25-apollo_propeller_widen_shardindex_from_u32_to_u64 branch from bad7a71 to 25ed97a Compare March 5, 2026 10:02
@sirandreww-starkware sirandreww-starkware force-pushed the 02-25-apollo_propeller_widen_shardindex_from_u32_to_u64 branch from 25ed97a to f337800 Compare March 5, 2026 10:39
@sirandreww-starkware sirandreww-starkware force-pushed the graphite-base/12878 branch 2 times, most recently from 93e338f to fb2307d Compare March 5, 2026 12:24
@sirandreww-starkware sirandreww-starkware force-pushed the 02-25-apollo_propeller_widen_shardindex_from_u32_to_u64 branch from f337800 to a054a16 Compare March 5, 2026 12:24
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/12878 to 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test March 5, 2026 12:24
Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).

@sirandreww-starkware sirandreww-starkware force-pushed the 02-25-apollo_propeller_widen_shardindex_from_u32_to_u64 branch from a054a16 to addb197 Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test branch from fb2307d to 8d224ab Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware changed the base branch from 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test to graphite-base/12878 March 17, 2026 12:49
@sirandreww-starkware sirandreww-starkware force-pushed the 02-25-apollo_propeller_widen_shardindex_from_u32_to_u64 branch from addb197 to bfddfc0 Compare March 17, 2026 13:01
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/12878 to 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test March 17, 2026 13:02
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

:lgtm:

@ShahakShama reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).

@sirandreww-starkware sirandreww-starkware changed the base branch from 02-24-apollo_propeller_e2e_test_infra_and_basic_broadcast_test to main March 19, 2026 16:24
@github-actions
Copy link

Artifacts upload workflows:

@sirandreww-starkware sirandreww-starkware removed the request for review from noamsp-starkware March 21, 2026 09:56
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Mar 21, 2026
Merged via the queue into main with commit 9b8683f Mar 21, 2026
68 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants