Skip to content

starknet_api: change Proof from u32 to u8#13367

Merged
avivg-starkware merged 1 commit intomain-v0.14.2from
avivg/starknet_api/proof_to_u8
Mar 19, 2026
Merged

starknet_api: change Proof from u32 to u8#13367
avivg-starkware merged 1 commit intomain-v0.14.2from
avivg/starknet_api/proof_to_u8

Conversation

@avivg-starkware
Copy link
Contributor

@avivg-starkware avivg-starkware commented Mar 19, 2026

Note

High Risk
Changes the on-the-wire and persisted representation of client-side proofs (protobuf field type and starknet_api::Proof storage/serde), which can break compatibility with existing nodes, stored proofs, and clients. Also increases accepted proof sizes, impacting resource usage and validation limits.

Overview
Switches client-side transaction Proof from Vec<u32> to raw Vec<u8> across the stack, updating base64 (de)serialization, protobuf InvokeV3WithProof.proof from repeated uint32 to bytes, filesystem proof storage read/write, and related tests/fixtures.

Raises the configured max_proof_size limit from 120000 to 480000 in gateway defaults, deployment configs, node schema, and blockifier versioned constants, and adds temporary u8↔u32 conversion checks in the prover/verifier while upstream PrivacyProofOutput still expects u32.

Written by Cursor Bugbot for commit 9d5622f. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@avivg-starkware avivg-starkware marked this pull request as ready for review March 19, 2026 14:25
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@avivg-starkware avivg-starkware force-pushed the avivg/starknet_api/proof_to_u8 branch 2 times, most recently from aef0ea6 to 102241d Compare March 19, 2026 14:57
@avivg-starkware
Copy link
Contributor Author

crates/apollo_protobuf/src/proto/p2p/proto/transaction.proto line 71 at r2 (raw file):

message InvokeV3WithProof {
    InvokeV3 invoke = 1;
    bytes proof = 2;

opened a specs PR https://reviewable.io/reviews/starknet-io/starknet-p2p-specs/78

Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@avi-starkware reviewed 18 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on noaov1).

@avivg-starkware avivg-starkware force-pushed the avivg/starknet_api/proof_to_u8 branch from 102241d to 9d5622f Compare March 19, 2026 18:27
Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivg-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on noaov1).

Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivg-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

@avivg-starkware avivg-starkware added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main-v0.14.2 with commit 8144234 Mar 19, 2026
50 of 73 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants