starknet_api: change Proof from u32 to u8#13367
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
aef0ea6 to
102241d
Compare
|
opened a specs PR https://reviewable.io/reviews/starknet-io/starknet-p2p-specs/78 |
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 18 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on noaov1).
102241d to
9d5622f
Compare
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on noaov1).
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noaov1).


Note
High Risk
Changes the on-the-wire and persisted representation of client-side proofs (protobuf field type and
starknet_api::Proofstorage/serde), which can break compatibility with existing nodes, stored proofs, and clients. Also increases accepted proof sizes, impacting resource usage and validation limits.Overview
Switches client-side transaction
ProoffromVec<u32>to rawVec<u8>across the stack, updating base64 (de)serialization, protobufInvokeV3WithProof.prooffromrepeated uint32tobytes, filesystem proof storage read/write, and related tests/fixtures.Raises the configured
max_proof_sizelimit from120000to480000in gateway defaults, deployment configs, node schema, and blockifier versioned constants, and adds temporary u8↔u32 conversion checks in the prover/verifier while upstreamPrivacyProofOutputstill expectsu32.Written by Cursor Bugbot for commit 9d5622f. This will update automatically on new commits. Configure here.