Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace winapi with windows-sys #70

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented May 6, 2024

windows-sys is maintained better, and this change simplifies the code a bit and lets us get rid of many of the existing manual bindings.
windows-sys will hopefully lead to fewer breaking changes than windows and it also maps more closely to winapi.

Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidkna davidkna merged commit 7f69364 into starship:main Aug 31, 2024
27 checks passed
@davidkna davidkna deleted the windows-sys branch August 31, 2024 11:27
@davidkna
Copy link
Member Author

Thanks for the review @matchai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants