[ros_bridge][py] Allow passing RTC list from hironx.py client. #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rtclist` arg wasn't used in `hironx_ros_bridge/hironx_client.py`. Rename it to express its usage is private only and utilize it for future purpose.
130s
force-pushed
the
fix/nextage_308
branch
13 times, most recently
from
1f292cc to
080e79c
Compare
130s
changed the title
130s
force-pushed
the
fix/nextage_308
branch
7 times, most recently
from
ea48d9e to
0f427c2
Compare
Contributor
Author
|
Travis passed. I will test this on a real robot before merging.
|
130s
added a commit
to 130s/rtmros_nextage
that referenced
this pull request
Apr 29, 2017
…#308). This requires the upstream change start-jsk/rtmros_hironx#497
This was referenced Apr 29, 2017
Open
This allows the downstream `nextage_ros_bridge` to add a patch to fix tork-a/rtmros_nextage#308. [ros_bridge][py][test] Export a testcase module that can be re-used.
Now that RTCs to activate is selectable from the end client (e.g. hironx.py), we need to expose all RTCs available. [ros_bridge][test][py] Refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YETWill fixThis will allow the downstream to fix an issue like tork-a/rtmros_nextage#308 with a minimal change.