Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid node clashing when USE_COLLISIONCHECK is true #528

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

Affonso-Gui
Copy link
Member

When USE_COLLISIONCHECK tag is true node clashing occurs in hironx_ros_bridge_real.launch:

roslaunch file contains multiple nodes named [/collision_state].
Please check all <node> 'name' attributes to make sure they are unique.
Also check that $(anon id) use different ids.
The traceback for the exception was written to the log file

This can be solved by not calling collision_detector.launch, which is already included by setting USE_COLLISIONCHECK to true.

The argument is also added in hironx_ros_bridge_real.launch, so we can set it from command line.

@pazeshun

@pazeshun
Copy link
Contributor

pazeshun commented Jun 29, 2018

Note 1:
In our hironx, collision detector rtc (co.rtc) can be running thanks to #423 , so we want to set USE_COLLISIONCHECK to true in hrpsys_ros_bridge.launch and use CollisionDetectorServiceROSBridge.
Otherwise (setting USE_COLLISIONCHECK to false), that bridge doesn't bring up.

@pazeshun
Copy link
Contributor

Note 2:
collision_detector.launch newly launches and uses collision detector rtc outside robot, while setting USE_COLLISIONCHECK to true in hrpsys_ros_bridge.launch uses collision detector rtc inside robot.

@pazeshun
Copy link
Contributor

pazeshun commented Jul 7, 2018

@k-okada I think this PR harms nothing. Would you please review this?

@pazeshun
Copy link
Contributor

pazeshun commented Nov 2, 2018

@k-okada Travis passed thanks to #531 . Please review this.

@k-okada k-okada merged commit 089a369 into start-jsk:indigo-devel Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants