Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates specs to run on newer ruby versions, adds CGI.unescape to request.fullpath #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

code-bunny
Copy link

@code-bunny code-bunny commented Jan 20, 2025

What is the current behaviour?

  • Currently the specs do not run on Ruby versions 3.3.x and 3.4.x.
  • Pagination meta links in responses will return an escaped self link if this was passed into the request. (The other links in the meta data will be unescaped.)

What is the new behaviour?

  • Specs now run on newer Ruby versions
  • Unescape request.fullpath to match output from other pagination methods

Checklist

Please make sure the following requirements are complete:

  • [ x ] Tests for the changes have been added (for bug fixes / features)
  • [ x ] Docs have been reviewed and added / updated if needed (for bug fixes /
    features)
  • [ x ] All automated checks pass (CI/CD)

@code-bunny code-bunny changed the title updates specs to run on newer ruby versions Updates specs to run on newer ruby versions, adds CGI.unescape to request.fullpath Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant