fix: adjust regex replace to match WxH only at end of filename (vrporn.com)#2161
Merged
Maista6969 merged 2 commits intostashapp:masterfrom Jan 10, 2025
Merged
fix: adjust regex replace to match WxH only at end of filename (vrporn.com)#2161Maista6969 merged 2 commits intostashapp:masterfrom
Maista6969 merged 2 commits intostashapp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scraper type(s)
Examples to test
Short description
Though #2159 was an improvement to get higher resolution images, there is an edge case where the filename includes more than one WxH occurrence, e.g.
https://vrporn.com/trans-the-best-teen-compilation/
has
https://mcdn.vrporn.com/files/20240925170921/The-Best-Teen-Compilation_Hard_slider-2000x1000-1-1000x562.jpg
which needs to only remove the -WxH at the end to become
https://mcdn.vrporn.com/files/20240925170921/The-Best-Teen-Compilation_Hard_slider-2000x1000-1.jpg
which exists
This regex replace adjustment achieves this.