-
-
Notifications
You must be signed in to change notification settings - Fork 480
Updated image extraction to pull cover image rather than one of the s… #2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ok, I'll check and compare the resulting scraped images, hopefully later today |
I have to use CDP configured with a VPN in order to access the sites... this doesn't resolve the site access for some sites for me Here is what I get with my current version of the scraper:
afaik, this |
For the arporn example, the proposed xpath for the image can be simplified to:
This resolves to https://content.arporn.com/uploads/2024/12/676338ee0c168851352077.jpg which is 2000x714 (very wide aspect) which will result in the sides being cropped in a Stash thumbnail. I would consider this image more of a banner image for the scene. The existing xpath resolves the first expression to https://content.arporn.com/uploads/2024/12/676338ee0c944958049212.jpg which is 1300x731 (16:9 aspect ratio) which is much more suitable in a Stash thumbnail... this image is the one that is shown in the video player. The proposed xpath fetches a very wide aspect ratio version of the cover image which isn't really suitable for Stash thumbnails vrconk: proposed: https://content.vrconk.com/uploads/2023/04/643f0910087a8445965650.jpg --> 2000x714 (very wide aspect ratio) vrbangers: proposed: https://content.vrbangers.com/uploads/2024/11/6733d704cba33825192694.jpg --> 2000x714 (very wide aspect ratio) so, from this limited set of example URLs, arporn and vrconk look like they can use the image of the video player as that is a 16:9 version of the cover image, whereas vrbangers seems to at least sometimes just use an image from the photo set what is slightly annoying is that the 16:9 cover image version for "Panty Hunter" does exist, it's just that you often have to find it at vrporn instead, e.g. https://vrporn.com/panty-hunter/ gives https://mcdn.vrporn.com/files/20250213003950/Panty-Hunter-Melanie-Marie-VR-Bangers-vr-porn-video.jpg which is 1300x731 (16:9 aspect ratio) interestingly, https://vrporn.com/special-after-party/ is also there, as is https://vrporn.com/god-of-war-freya-a-porn-parody/ which gives a 1300x731 cover image https://mcdn.vrporn.com/files/20230811083807/God-Of-War-Freya-A-Porn-Parody-Armani-Black-VRConk-vr-porn-video-1.jpg, higher resolution than at vrconk.com as the slugs are identical, maybe this scraper could add a secondary URL for |
TL;DR:
|
Agreed, closing PR. Will see if it's possible to add alt selector just for one site |
…ample images.
Generated by an automatic template. Can be removed if not applicable.
Scraper type(s)
Examples to test
https://vrconk.com/video/god-of-war-freya-a-porn-parody/
https://arporn.com/video/special-after-party/
https://vrbangers.com/video/panty-hunter/
Images were pulling sample images which were inconsistent. I've updated it to retrieve the cover art.