-
-
Notifications
You must be signed in to change notification settings - Fork 484
MyMemberSite: support all sites, fetch studio info from API, parse API URL from HTML response #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MyMemberSite: support all sites, fetch studio info from API, parse API URL from HTML response #2525
Conversation
a826154
to
3c3fbf4
Compare
…I URL from HTML response Signed-off-by: Rubber Roman <[email protected]>
3c3fbf4
to
9bb5936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped looking because the list is so long..
Signed-off-by: Rubber Roman <[email protected]>
Signed-off-by: Rubber Roman <[email protected]>
Ran it through n++, there is ONE duplicate line still 😭 Edit, it was python3 thank god |
with so many lines, this might actually cause problems for the parsers, I don't think it makes sense to list out all the domain paths underneath mymember.site, it would be easier just to do |
@feederbox826 Is it better now? Now I used only domains and referenced the URL list to reduce the number of lines in the scraper definition. |
…line count Signed-off-by: Rubber Roman <[email protected]>
b79b800
to
b233cd4
Compare
Signed-off-by: Rubber Roman <[email protected]>
It looks fine at a glance now, but I haven't tested it. |
Busy with life and got lost in my head, looks good at a glance, will try to give it a test now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validate scene aginst base and custom domain
Scraper type(s)
Examples to test
Short description
Support all sites from MyMemberSite network.