Skip to content

Conversation

@bunkmate5127
Copy link
Contributor

Functional fix:

  • Replaced deprecated call to stash's old function "create_movie()" with its new function "create_group()". Will remove the deprecation warning from the stash log.

Tidying up the code:

  • Changed all variable and function names from referring to 'movies', to referring to the new terminology of 'groups' for consistency with the stash call. ('m'→'g', 'movie'→'group', 'mov'→'grp')
  • Note: no change to moniker 'm' when used to represent a short-form for "marker".

- Replaced  deprecated call to function create_movie() with create_group()
- Changed all local variable names from referring to movies, to referring to the new terminology of groups for consistency with the stash call.
- Changed monikers that were short for "movie" with new monikers short for "group".
- Note: no change to moniker 'm' when used to represent a short-form for "marker".
@bunkmate5127 bunkmate5127 changed the title Fix create_movie() deprecation Fix create_movie() deprecation in TMDBMarkers Plugin Aug 27, 2025
@Tweeticoats
Copy link
Contributor

I would keep the setting as createMovieFromScene as that is what the yaml has as the setting and that is the setting to toggle in the ui. I would recommend you update the yaml file and change the description of the setting.

@bunkmate5127
Copy link
Contributor Author

I would keep the setting as createMovieFromScene as that is what the yaml has as the setting and that is the setting to toggle in the ui. I would recommend you update the yaml file and change the description of the setting.

Does stash have no viable migration pathway for variable names in plugin yaml files?

- Reflects "group" moniker now used in stash, instead of the old "movie" moniker. Variable name left intact as "createMovieFromScene" it's apparently non-trivial to change this within stash's plugin ecosystem.
- Non-trivial within stash to migrate this setting to "createGroupFromScene" to reflect the new moniker used for "groups" instead of "movies".
@bunkmate5127
Copy link
Contributor Author

I've made these changes that you've requested (I overlooked the yaml, thanks for pointing it out).

My preferred solution would be to have instead of this regression to "createMovieFromScene" name instead have a migration. But I don't know what facility or schema the wider stash plugin system has (if any) to migrate historical plugin settings to new names. I accept that this might be non-trivial.

@Tweeticoats
Copy link
Contributor

Line 182 should remain "createMovieFromScene"

@bunkmate5127
Copy link
Contributor Author

...When a man can't even ctrl+h properly XD.

Sorry for the trouble, should be good now.

Copy link
Contributor

@Tweeticoats Tweeticoats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@DogmaDragon DogmaDragon merged commit a313a93 into stashapp:main Aug 30, 2025
1 check passed
@bunkmate5127 bunkmate5127 deleted the patch-1 branch September 3, 2025 03:14
@DogmaDragon DogmaDragon added type:plugin Plugins object:marker Affects or is triggered by marker object labels Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

object:marker Affects or is triggered by marker object type:plugin Plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants