-
-
Notifications
You must be signed in to change notification settings - Fork 199
Fix create_movie() deprecation in TMDBMarkers Plugin #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replaced deprecated call to function create_movie() with create_group() - Changed all local variable names from referring to movies, to referring to the new terminology of groups for consistency with the stash call.
- Changed monikers that were short for "movie" with new monikers short for "group". - Note: no change to moniker 'm' when used to represent a short-form for "marker".
|
I would keep the setting as createMovieFromScene as that is what the yaml has as the setting and that is the setting to toggle in the ui. I would recommend you update the yaml file and change the description of the setting. |
Does stash have no viable migration pathway for variable names in plugin yaml files? |
- Reflects "group" moniker now used in stash, instead of the old "movie" moniker. Variable name left intact as "createMovieFromScene" it's apparently non-trivial to change this within stash's plugin ecosystem.
- Non-trivial within stash to migrate this setting to "createGroupFromScene" to reflect the new moniker used for "groups" instead of "movies".
|
I've made these changes that you've requested (I overlooked the yaml, thanks for pointing it out). My preferred solution would be to have instead of this regression to "createMovieFromScene" name instead have a migration. But I don't know what facility or schema the wider stash plugin system has (if any) to migrate historical plugin settings to new names. I accept that this might be non-trivial. |
|
Line 182 should remain "createMovieFromScene" |
|
...When a man can't even Sorry for the trouble, should be good now. |
Tweeticoats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
Functional fix:
Tidying up the code: