Allow "Read" Role to Edit Favorite Notifications #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
They are not "admin" notifications. They require EDIT role to use. Using admin terminology makes no sense. |
Author
|
You are right. I changed it from admin to editor. Do you like this better or do you have another proposal? |
Author
|
I fixed the failing pipeline. |
Author
|
@DogmaDragon Do you agree with the renaming from admin to editor subscriptions? |
Contributor
|
That sounds better to me, but @InfiniteStash has the final say. |
Author
|
@InfiniteStash what are your thoughts on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #927, normal users cannot set notifications for their favorite studios and performers. This PR remedies the issue by adding a second API call
updateFavoriteNotificationSubscriptionsrequiring only theREADrole. In the backend, a check is performed, such that indeed only the favorite notifications can be edited (other notifications are filtered out and cannot be set via the call).