Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various tooltips #4264

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

elkorol
Copy link
Contributor

@elkorol elkorol commented Nov 5, 2023

This pr adds the react bootstrap Tooltip to various elements where similar elements already use it. Bringing these elements into conformity with the rest of the ui.

Areas affected

  • maybeRenderOrganized in GalleryCard and SceneCard
  • maybeRenderFlag in PerformerCard, which I've included an extra parameter of includeOverlay to the component. So that the rendered country flag in the performers detail header, where it renders the name alongside the flag. Doesn't have a tooltip.
  • In the PopoverCountButton. I've included markers and for it to generate a tooltip. And made it to generate a tooltip by default to bring conformity of other ui elements to these elements.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Nov 20, 2023
@WithoutPants WithoutPants added this to the Version 0.24.0 milestone Nov 20, 2023
@WithoutPants WithoutPants merged commit d95ef40 into stashapp:develop Nov 21, 2023
2 checks passed
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants