Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pip externally-managed-environment error #4360

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

DingDongSoLong4
Copy link
Collaborator

Alpine seems to have finally enabled Python's externally managed environment warning as specified in PEP 668, which is now causing the CI docker build to fail.

The fix here is to simply use --break-system-packages, which ignores the warning. Given that this is a Docker container, I don't think we really need to worry about breaking anything, and it's been fine up to now anyway. I've added --user as well just to be on the safe side, so it will install packages to ~/.local/lib/python3.11/site-packages rather than /usr/lib/python3.11/site-packages.

And then I've just added a missing PHONY target to the Makefile and added a vim modeline to Dockerfile-CUDA to enable syntax highlighting.

@WithoutPants WithoutPants added the chore Pull requests for refactoring and admin work label Dec 14, 2023
@WithoutPants WithoutPants added this to the Version 0.24.0 milestone Dec 14, 2023
@WithoutPants WithoutPants merged commit 43a9df8 into stashapp:develop Dec 14, 2023
2 checks passed
@DingDongSoLong4 DingDongSoLong4 deleted the dockerfile-pip branch December 14, 2023 12:06
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Add missing Makefile PHONY target
* Add Dockerfile-CUDA vim modeline
* Fix CI pip externally-managed-environment error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for refactoring and admin work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants