Use int64 for sample-related FFProbeStream fields #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix for an bug that came up in Discord, where scanning throws an ffprobe unmarshal error if you scan really long files on a 32-bit system. This is because
duration_tscan sometimes, for really long files, be too large for a signed 32-bit integer, which is what theinttype is an alias for on 32-bit systems.I've thus just replaced the
intwithint64on theDurationTsfield to solve the issue. I've also made the same change onStartPts, just to be safe, since that is a value that is also measured in samples. Neither of these values are actually ever used anyway.