-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zoom slider to other grid views #4674
base: develop
Are you sure you want to change the base?
Add zoom slider to other grid views #4674
Conversation
Hmm, I was under the impression that the zoom level wasn't stored in saved filters, but that does not seem to be the case. I don't think anything else needs to be done here. |
I can see merit in a zoom slider for movie cards, but is there really a need for zooming of performer and studio cards? |
I remember Echo specifically requested the zoom slider on the performer page so he could fit more of those cards on his screen https://discord.com/channels/559159668438728723/644934273459290145/1204623730895228989. Everything else was just for consistency. |
Of the new additions, I’d probably only use the slider to reduce the size of the movie cards. I’m not against removing the slider on the studio page, but with the sliders on all the other pages, it seems like we might as well include it. |
Going to reference the FR here so that it's easier to track. |
This branch is up to date with the latest changes in the development branch. |
This pull request brings the zoom slider to the movie, performer, and studio pages. It makes sense to save the state of the zoom index for each page, but to minimize conflicts, it probably makes sense to wait until #4453 is merged.
Closes #2201