Fix UI plugin race conditions#5523
Merged
WithoutPants merged 2 commits intostashapp:developfrom Dec 2, 2024
Merged
Conversation
Also moves plugin code into plugins.tsx
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Jan 16, 2025
* useScript to return load state of scripts * Wait for scripts to load before rendering Also moves plugin code into plugins.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved plugin loading code into plugins.tsx and changed so that the app does not render until the plugin javascript files are loaded and parsed. This should resolve the race condition described in #5124.
Resolves #5124