Update performer gender filter in identify dialog #5588
Closed
+72
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4096 Deprecate `includeMalePerformers` field in favor of `performerGenders` field in the GraphQL schema and update the UI to support gender selection. * **GraphQL Schema Changes:** - Add `performerGenders: [GenderEnum!]` field to `IdentifyMetadataOptionsInput` type. - Deprecate `includeMalePerformers` field in `IdentifyMetadataOptionsInput` type. - Add `performerGenders` field to `SceneFilterType` and `PerformerFilterType` inputs. * **API Changes:** - Update `FindPerformers` method in `resolver_query_find_performer.go` to filter performers based on `performerGenders` field. - Update `FindScenes` method in `resolver_query_find_scene.go` to filter scenes based on `performerGenders` field. - Update `getOptions` and `getSceneUpdater` methods in `identify.go` to handle `performerGenders` field. * **UI Changes:** - Update `getDefaultOptions` and `makeIdentifyInput` functions in `IdentifyDialog.tsx` to include `performerGenders` field. - Add new input for selecting performer genders in `Options.tsx` using `MultiSelectDropdown` component. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/stashapp/stash/issues/4096?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4096
Deprecate
includeMalePerformersfield in favor ofperformerGendersfield in the GraphQL schema and update the UI to support gender selection.GraphQL Schema Changes:
performerGenders: [GenderEnum!]field toIdentifyMetadataOptionsInputtype.includeMalePerformersfield inIdentifyMetadataOptionsInputtype.performerGendersfield toSceneFilterTypeandPerformerFilterTypeinputs.API Changes:
FindPerformersmethod inresolver_query_find_performer.goto filter performers based onperformerGendersfield.FindScenesmethod inresolver_query_find_scene.goto filter scenes based onperformerGendersfield.getOptionsandgetSceneUpdatermethods inidentify.goto handleperformerGendersfield.UI Changes:
getDefaultOptionsandmakeIdentifyInputfunctions inIdentifyDialog.tsxto includeperformerGendersfield.Options.tsxusingMultiSelectDropdowncomponent.For more details, open the Copilot Workspace session.