-
-
Notifications
You must be signed in to change notification settings - Fork 930
get sidebar to use all available vertical space #6179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
get sidebar to use all available vertical space #6179
Conversation
|
This simplest way forward would be to remove (or override to If we were to take this approach, I'd want to do some sticky positioning of the section headers and ideally the search input for the section as well. This allows the user to easily filter on whatever criterion they are scrolling through, or close the section to peruse other sections. |
|
Here's a quick and dirty prototype: https://github.com/WithoutPants/stash/tree/prototyping/sidebar-no-extra-scrollbars The headers are stickied, but the search filter inputs are not. The behaviour when closing a scrolled section is a bit weird as well, but probably not enough to be a problem. |
It works OK, has a few points thought * collapse / expand animations seem to target original height * the space use is still not efficient, because all open boxes get equal spacing, irregardless of content height * unsure about the :has() pseudo-class, it' pretty newish (2022 / 2023)
This reverts commit 6197fdd.
This reverts commit 725c778.
…element the goal is to keep selected options visble when scrolling, not just the section header
6197fdd to
b9fe590
Compare

I've been messing with some CSS to get the new sidebar to use all the vertical space it has available, since I found the default behavior to use max 300px per filter list imperfect.
Due to the scroll-able filter item list
<ul>inside each box, this gets messy. The approach is, that everything from the fixed position sidebar down to the filter item list<ul>needs to be vertical flexbox, to leverage shrink / grow to dynamically size each filter box.I'm mostly looking for some feedback and some tips (hence the draft).
It works OK, but has a few issues
Screenshots