-
-
Notifications
You must be signed in to change notification settings - Fork 930
FR: Add Duration Slider to Sidebar Filters #6264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
IMO the presets should be a bit wider range, will try to run a sample in stash for it 🤔 |
|
Testing notes:
Pornhub uses 10 minute steps, up to a maximum of 40+ minutes. I think a max range of 2+ hours is good, but I think the steps could be better. Trying to set 0 - 2 minute range is pretty fiddly. Having steps of 0, 2 minute, 5 minute, then 5 minute intervals is what I propose, but I'm happy to discuss it. It means that the steps won't be completely one-to-one given that first 2 minute step. |
|
IMO the end one should be on the higher Z index (front) |
Yea, the end is 3 and min is 1 iirc |
|
Very nice work. I managed to make the max slider track transparent so that the min thumb is more visible:
I also added left/right align to the min and max text inputs. I separated out the slider control into a reusable component so that it can be reused in other things. Please update #6267 once this is merged to use the new component. Finally, I changed the debounce implementation to use our specialised |
|
having a look now |
feederbox826
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not many scenes to test with, but one UX request would be make the un-selected range greyed out compared to the selected range being in blue
Fair point. We would have to do away with using range inputs entirely to implement this though, as far as I can determine (Pornhub appear to do this with div, span and some styling). A simpler - albeit workaround - solution may be to make the slider track a more neutral colour instead of the primary blue color. |

This PR allows the user to use a customizable slider to filter by duration similar to PH.
Currently there are 5 presets as shown in the screenshot below. I have set the current max to 2 hours but this can be modified if we feel like it needs to be higher. Just a reminder, the higher on the max we go the "longer" the slider becomes. Makes it harder for users to make smaller adjustments using the slider.
The users can modify the time in 3 ways:
As you can see there are various ways for the user to set their desired time.
Closes: #6263
UI:
