feat: Adding basic main portrait layout #18012
Conversation
alexjba
requested review from
micieslak,
a team,
caybro and
noeliaSD
as code owners
alexjba
requested review from
dlipicar and
Cuteivist
and removed request for
a team
Jenkins BuildsClick to see older builds (24)
|
There was a problem hiding this comment.
The new component is probably not working with Qt5, as the failing ui-tests suggest:
[2025-05-29T09:52:51.451Z] Running: StatusQ SanityChecker
[2025-05-29T09:52:51.817Z] (file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-18012/ui/StatusQ/src/StatusQ/Layout/StatusSectionLayoutPortrait.qml:150:37: Expected token `numeric literal'
[2025-05-29T09:52:51.817Z] property list<Item> items: []
[2025-05-29T09:52:51.817Z] ^)
[2025-05-29T09:52:51.817Z] (file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-18012/ui/StatusQ/src/StatusQ/Layout/LayoutChooser.qml:11:36: Unexpected token `]'
[2025-05-29T09:52:51.817Z] property list<bool> criteria: []
[2025-05-29T09:52:51.818Z] ^, file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-18012/ui/StatusQ/src/StatusQ/Layout/LayoutChooser.qml:12:14: Syntax error
[2025-05-29T09:52:51.818Z] property list<var> layoutChoices: []
[2025-05-29T09:52:51.818Z] ^)
[2025-05-29T09:52:51.818Z] (file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-18012/ui/StatusQ/src/StatusQ/Layout/StatusSectionLayoutLandscape.qml: Library import requires a version)
8d6b4e9 to
ebbaec6
Compare
alexjba
force-pushed
the
feat/basic-portrait-layout
branch
from
ebbaec6 to
ba99866
Compare
Introducing `LayoutChooser` component from qml tests: https://codereview.qt-project.org/c/qt/qtdeclarative/+/456325/54/tests/manual/quicklayouts/layoutItemProxy/LayoutChooser.qml The LayoutChooser is used to change the "StatusSectionLayout" from a SplitView to a SwipeView in portrait mode whenever the width is less than the implicitWidth. Other changes: Maintain compoatibility with qt5 Basic navigastion on item selection (channels, contacts, settings, accounts)
alexjba
force-pushed
the
feat/basic-portrait-layout
branch
from
1ef2ab5 to
2e142ce
Compare
The app goes into portrait mode the height is higher than the width and the width is smaller than the window minimum width
alexjba
force-pushed
the
feat/basic-portrait-layout
branch
from
2e142ce to
4aef81d
Compare
|
@caybro please have another look. Had to resolve quite a few conflicts with the Shell |
Looks good, although I can only see one line touched in AppMain.qml that mentions shell? |
Got me worried for a second! But yeah, you're right. Ignoring the whitespace it's only a line. 😄 The main change is that the shell bar (along with the app nav bar) now lives in AppMain and is shared in between StatusSectionLayouts. It's no longer in the |
|
@status-im/devops any idea what could be wrong with the aarch64 build? This PR is on top of #18066 that adds openssl as a vendor. But here it seems the openssl submodule can't be initialized. |
Yeah and I think that's gonna conflict a bit with one of @jrainville PRs where he made the Shell a section on its own |
What does the PR do
Introducing
LayoutChoosercomponent from qml tests: https://codereview.qt-project.org/c/qt/qtdeclarative/+/456325/54/tests/manual/quicklayouts/layoutItemProxy/LayoutChooser.qmlThe LayoutChooser is used to change the "StatusSectionLayout" from a SplitView to a SwipeView in portrait mode whenever the width is less than the implicitWidth.
Other changes:
Maintain compoatibility with qt5
Basic navigastion on item selection (channels, contacts, settings, accounts)
Affected areas
App layout, navBar
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2025-05-29.at.12.41.40.mov