Fix shell's chats not being loaded at start and missing image #18039
+315
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
a team,
micieslak,
caybro,
alexjba and
noeliaSD
as code owners
Jenkins BuildsClick to see older builds (19)
|
caybro
force-pushed
the
feat/shell-mode-home
branch
from
971272a to
3fb9f3c
Compare
jrainville
force-pushed
the
fix/shell-chat-section-load
branch
from
4b86e25 to
ae50745
Compare
jrainville
force-pushed
the
fix/shell-chat-section-load
branch
from
ae50745 to
3f37f24
Compare
alexjba
approved these changes
Jun 9, 2025
Fixes #18030 I moved the initialization of the chats to the Nim side. The personal section's chats get loaded on app start now. It will impact the login a little, but not much, since it only loads the model of chats, not messages. For the image issue, the problem was that the ShellAdaptor didn't have the `chatType` as an `expectedRole`. Same for `onlineStatus`. I guess there is a bug in the SFPM where without the expectedRole, it's undefined at first, but then when you reload the page it works, the bug being that it somehow works on reload.
Changes Item to ChatIte. initItem to initChatItem. Plus some clean ups to unused imports. Adds use of `updateRole` to the model to clean up the code. Adds a test file for the chat Model
jrainville
force-pushed
the
fix/shell-chat-section-load
branch
from
3f37f24 to
ded14fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #18030
I moved the initialization of the chats to the Nim side. The personal section's chats get loaded on app start now. It will impact the login a little, but not much, since it only loads the model of chats, not messages.
For the image issue, the problem was that the ShellAdaptor didn't have the
chatTypeas anexpectedRole. Same foronlineStatus. I guess there is a bug in the SFPM where without the expectedRole, it's undefined at first, but then when you reload the page it works, the bug being that it somehow works on reload.I also did a clean up of the chat Item and Model because I was annoyed that we always use Item.
Changes Item to ChatItem. initItem to initChatItem.
Plus some clean ups to unused imports.
Adds use of
updateRoleto the model to clean up the code.Adds a test file for the chat Model
Affected areas
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Impact on end user
Fixes the issue
How to test
FLAG_SHELL_ENABLED=1Risk
Described potential risks and worst case scenarios.
Tick one: