fix(shell): fix chat being active in the background of the shell #18088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba,
noeliaSD and
a team
as code owners
jrainville
commented
Jun 6, 2025
| @@ -167,7 +167,6 @@ QtObject: | |||
|
|
|||
| proc activeSectionSet*(self: View, item: SectionItem) = | |||
| self.activeSection.setActiveSectionData(item) | |||
| self.activeSectionChanged() | |||
There was a problem hiding this comment.
This was useless. It just made it so that we called the update twice.
| @@ -55,8 +55,7 @@ SplitView { | |||
| } | |||
|
|
|||
| Control { | |||
| SplitView.minimumWidth: 78 | |||
| SplitView.preferredWidth: 78 | |||
| SplitView.preferredWidth: !!leftPanel && leftPanel.visible ? leftPanel.width : 0 | |||
There was a problem hiding this comment.
This is to keep the previous behaviour of the shell being full screen. IMO, it looks fine when the tabbar is still shown when the Shell is visible, but we can easily revert.
| @@ -51,7 +51,8 @@ Control { | |||
| spacing: Theme.bigPadding | |||
|
|
|||
| function focusSearch() { | |||
| searchField.forceActiveFocus() | |||
| // Need to use Qt.callLater to ensure the focus is set after the component is fully loaded | |||
| Qt.callLater(() => searchField.forceActiveFocus()) | |||
There was a problem hiding this comment.
Since the Shell is shown at the start for real now (loaded by the main module), it loaded too fast and the focus didn't apply
| @@ -1819,6 +1808,93 @@ Item { | |||
| // If we ever change stack layout component order we need to updade | |||
| // Constants.appViewStackIndex accordingly | |||
|
|
|||
| Loader { | |||
There was a problem hiding this comment.
I didn't really change anything here, just moved it in the StackLayout
Jenkins Builds
|
jrainville
force-pushed
the
feat/expose-last-message
branch
from
96fb531 to
f73e740
Compare
jrainville
force-pushed
the
feat/expose-last-message
branch
from
f73e740 to
98149ad
Compare
Fixes #18059 Fixes the issue by putting the Shell as part of the sections themselves. that way we ensure that no other section is active in the background for no reason. It simplifies the code a little since we no longer need a custom shell button
jrainville
force-pushed
the
fix/active-chat-badge-in-shell
branch
from
fc218ea to
006e663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #18059
Fixes the issue by putting the Shell as part of the sections themselves. that way we ensure that no other section is active in the background for no reason. It simplifies the code a little since we no longer need a custom shell button
Affected areas
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
chat-in-background-shell.webm
Impact on end user
Fixes the issue of chat messages being marked as read even if not shown to the user. Nothing in the background when in the shell, so no risk of side effects
How to test
Risk
Tick one: