fix(wallet)_: enrich status changed and tx update signals' payload with tx route data #6050
+1,517
−1,284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (40)
|
saledjenic
changed the title
saledjenic
force-pushed
the
fix/tx-signals-enrich-data
branch
from
1a92352
to
9f0261c
Compare
saledjenic
changed the title
saledjenic
requested review from
alaibe,
shivekkhurana,
dlipicar,
briansztamfater and
smohamedjavid
dlipicar
reviewed
Nov 6, 2024
| import "github.com/status-im/status-go/errors" | ||
|
|
||
| var ( | ||
| ErrInvalidSignatureDetails = &errors.ErrorResponse{Code: errors.ErrorCode("WT-004"), Details: "invalid signature details"} |
There was a problem hiding this comment.
errors of a given type should all be in the same file IMO, hard to track down which error code I need to use for the next one otherwise. If this was causing a circular dependency we might need a separate errors package under the router dir or wherever this used to be
dlipicar
reviewed
Nov 6, 2024
| UsdcSymbol = "USDC" | ||
| HopSymbol = "HOP" | ||
|
|
||
| ProcessorTransferName = "Transfer" |
There was a problem hiding this comment.
hmm these don't really sound like a "common" thing, it's a very pathprocessor-specific thing. I'd favour doing a new package like pathprocessortypes or something like that if it casuses circular dependency, otherwise the common package will just become a dump of every constant used in more than one place.
saledjenic
force-pushed
the
fix/tx-signals-enrich-data
branch
from
9f0261c
to
4a6f483
Compare
|
@dlipicar I agree with both things you've stated above, but was very hard to fix all cyclic dependencies, cause there were many, without such changes. We should think about and work more on sorting out the code organization for the wallet service. |
|
Changes I've done were necessary to have what I need for ephemeral notifications, which is the last commit in this PR. If you can apply the last commit on top of your changes done here #5970 solving all cyclic dependencies with better code organization I am up for that. We should have a separate PR where we will clean the wallet service and improve its architecture. Also, because of many things that are potentially used by mobile app, we cannot fully clean them. I hope things will get better once the mobile app starts using a new sending flow and all txs (for ens usernames, collectibles, stickers, other txs) go over the router and new sending flow. |
dlipicar
force-pushed
the
feat/store-route-execution-data
branch
3 times, most recently
from
2b16ad1
to
ddfcc79
Compare
saledjenic
force-pushed
the
fix/tx-signals-enrich-data
branch
from
4a6f483
to
a30cc4c
Compare
saledjenic
force-pushed
the
fix/tx-signals-enrich-data
branch
2 times, most recently
from
fc6637e
to
ff68921
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6050 +/- ##
============================================
- Coverage 60.87% 13.33% -47.55%
============================================
Files 811 800 -11
Lines 108894 107756 -1138
============================================
- Hits 66293 14371 -51922
- Misses 34843 91533 +56690
+ Partials 7758 1852 -5906
Flags with carried forward coverage won't be shown. Click here to find out more.
|
New EnsResolver type identified and will be responsible for network calls, while ens api will use it (until mobile app switches to a new sending flow) and continue managing other (db) interactions.
- path processor constants moved to wallet constants - FetchPrices and FindToken functions moved from send type package to router package
…ith tx route data
saledjenic
force-pushed
the
fix/tx-signals-enrich-data
branch
from
ff68921
to
5786466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen, by commits, all but the last commit were necessary to get rid of cyclic dependencies I ran into when I wanted to add route tx data to the payload of the status-changed signal.
What's done:
SendTxArgstype defined and used across many packages) moved to services/wallet/wallettypesThese changes depend on the work done here #5970