test: Token gated communities #7113
Open
+585
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (540)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7113 +/- ##
============================================
+ Coverage 36.28% 59.56% +23.27%
============================================
Files 800 815 +15
Lines 111467 113558 +2091
============================================
+ Hits 40446 67639 +27193
+ Misses 65933 39071 -26862
- Partials 5088 6848 +1760
Flags with carried forward coverage won't be shown. Click here to find out more. |
Collaborator
igor-sirotin
left a comment
igor-sirotin
left a comment
There was a problem hiding this comment.
Thanks @romanzac! 👍
Looks good to me, just a few polishing suggestions
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
romanzac
force-pushed
the
test/token-gated-communities
branch
from
49ce18a to
d1a9df7
Compare
igor-sirotin
reviewed
Dec 4, 2025
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
tests-functional/tests/test_wakuext_community_token_permissions.py
Outdated
Show resolved
Hide resolved
| def setup_backends(self, backend_new_profile, foundry_client): | ||
| """Initialize backends for token permission tests""" | ||
| self.owner = backend_new_profile("owner") | ||
| self.member = backend_new_profile("member") |
Collaborator
There was a problem hiding this comment.
It's not good that we create both member and member_with_snt for all tests, using setup_backends.
self.member is only used in 1/3 tests. And self.member_with_snt is only used in the other 2.
This is a waste of time and also makes it more difficult to debug.
Perhaps we can define fixtures right here, and use them in specific tests? Like owner fixture, etc.
Collaborator
There was a problem hiding this comment.
Hmm, not sure if polluting conftest.py with this is a good idea, I'd rather keep these fixtures right next to the test.
But it's just my opinion, completely up to you.
igor-sirotin
force-pushed
the
test/token-gated-communities
branch
from
4aa8b34 to
77e3174
Compare
- test_admin_token_permissions_with_valid_tokens
- cleanup and add additional logging
- test_owner_edits_visible_before_and_after_minting_owner_token
Collaborator
|
I'm investigating why These tests are almost the same. And these 2 changes TOGETHER make
So, conclusion:
I'm continuing to investigate |
Collaborator
|
Okay I got both tests failing 🙂 Found this: |
Collaborator
|
Seems that I'm figuring out how to do it now. |
Collaborator
|
Blocked by: #7184 |
Contributor
Author
Introduced CustomTokens field in WalletConfig to allow registration of custom tokens, mainly necessary for the functional tests. Fixes #7184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An initial batch of functional tests to cover token-gated communities.
Tests Included
Issues discovered