feat(backup): implement emoji reaction backup #7163
+325
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (16)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7163 +/- ##
============================================
+ Coverage 35.00% 59.99% +24.98%
============================================
Files 798 813 +15
Lines 111323 113508 +2185
============================================
+ Hits 38972 68098 +29126
+ Misses 67476 38566 -28910
- Partials 4875 6844 +1969
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jrainville
force-pushed
the
feat/backup-emoji-reactions
branch
from
137d14e to
332cf3c
Compare
igor-sirotin
approved these changes
Dec 3, 2025
| LEFT JOIN pin_messages pm | ||
| ON pm.message_id = m1.id AND pm.pinned = 1 | ||
| LEFT JOIN emoji_reactions e | ||
| ON e.message_id = m1.id AND NOT(e.retracted) |
Collaborator
There was a problem hiding this comment.
Shouldn't AND NOT(e.retracted) be after WHERE? 🤔
Member
Author
There was a problem hiding this comment.
I guess both work. This makes it clear that it's a condition only on the emoji_reactions. Especially since the query is already a bit confusing, since it fetches the same message multiple times for the reactions.
protocol/message_persistence.go
Outdated
|
|
||
| rows, err := db.db.Query(query) | ||
| if err != nil { | ||
| if err == sql.ErrNoRows { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if err == sql.ErrNoRows { | |
| if errors.Is(err, sql.ErrNoRows) { |
jrainville
force-pushed
the
feat/backup-emoji-reactions
branch
2 times, most recently
from
0c4b472 to
b2c8f71
Compare
jrainville
force-pushed
the
feat/backup-emoji-reactions
branch
from
b2c8f71 to
b0c7910
Compare
Member
Author
|
@osmaczko friendly reminder to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-app#19343
Enables users to backup and sync emoji reactions along with messages during a pairing.
emoji-backup.webm