test: forward USE_NWAKU env var to the tests #7180
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
changed the title
|
Thank you for opening this pull request! We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted. Details:
|
Member
Jenkins BuildsClick to see older builds (22)
|
Ivansete-status
approved these changes
Dec 5, 2025
Contributor
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! Thanks for it! 💯
I suspect there may appear test errors on nwaku runs but we can fix them on separate PRs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7180 +/- ##
===========================================
- Coverage 36.28% 34.96% -1.33%
===========================================
Files 800 800
Lines 111467 111467
===========================================
- Hits 40446 38971 -1475
- Misses 65933 67624 +1691
+ Partials 5088 4872 -216
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
approved these changes
Dec 5, 2025
markoburcul
force-pushed
the
fix-nwaku-tests
branch
from
82dfd19 to
59a3d2d
Compare
Check if job name contains nwaku properly.
markoburcul
force-pushed
the
fix-nwaku-tests
branch
from
59a3d2d to
02abcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.