chore: use system nim always #7185
Open
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 9, 2025
1 task
Member
Jenkins BuildsClick to see older builds (60)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7185 +/- ##
===========================================
- Coverage 59.81% 58.74% -1.08%
===========================================
Files 822 822
Lines 113641 113515 -126
===========================================
- Hits 67978 66681 -1297
- Misses 38805 40025 +1220
+ Partials 6858 6809 -49
Flags with carried forward coverage won't be shown. Click here to find out more. |
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 10, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 10, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
Contributor
|
Thanks for that @siddarthkay ! I think it is also interesting to validate CI could pass as well on Status-Desktop, with this branch, before merging it, if @igor-sirotin agrees |
Contributor
Author
igor-sirotin
approved these changes
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
Whatever that works for everyone. Eventually we want to use Nimble anyway.
Thank you @siddarthkay!
jrainville
approved these changes
Dec 10, 2025
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 11, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 11, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
siddarthkay
force-pushed
the
use-system-nim-always
branch
from
ffbfdd6 to
708d87f
Compare
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 11, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 11, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
siddarthkay
force-pushed
the
use-system-nim-always
branch
from
708d87f to
4875a8d
Compare
siddarthkay
added a commit
to status-im/status-app
that referenced
this pull request
Dec 12, 2025
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
Contributor
Author
|
for RPC tests to pass I need to update |
To avoid running into issues like this on windows ``` [2025-12-08T15:14:54.159Z] fatal: '$GIT_DIR' too big [2025-12-08T15:14:54.159Z] fatal: clone of 'https://github.com/nim-lang/checksums.git' into submodule path 'J:/Users/jenkins/workspace/_windows_x86_64_package_PR-18965/vendor/status-go/Usersjenkinsworkspace_windows_x86_64_package_PR-18965@tmp/nim-sds/vendor/nimbus-build-system/vendor/Nim/dist/nimble/vendor/checksums' failed ```
siddarthkay
force-pushed
the
use-system-nim-always
branch
from
4e5c479 to
fee3eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid running into issues like this on windows