Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

Iterates #7067

Description

  1. Moved appdatabase -> internal/db/appdatabase
  2. Moved walletdb -> internal/db/walletdb
  3. Moved sqlite -> internal/db/sqlite
  4. Moved multiaccounts -> internal/db/multiaccounts
  5. Moved abi-spec -> internal/abi-spec
  6. Moved connection -> internal/connection

@github-actions
Copy link

Thank you for opening this pull request!

We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted.

Details:

No release type found in pull request title "сhore: project layout (databases, abi-spec, connection)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@status-im-auto
Copy link
Member

status-im-auto commented Dec 12, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 52e0af6 #1 2025-12-12 22:15:33 ~3 min linux/status-go 📦zip
52e0af6 #1 2025-12-12 22:16:15 ~4 min macos/nwaku 📄log
✔️ 52e0af6 #1 2025-12-12 22:16:27 ~4 min macos/status-go 📦zip
✔️ 52e0af6 #1 2025-12-12 22:19:16 ~7 min linux/nwaku 📦zip
✔️ 52e0af6 #1 2025-12-12 22:19:41 ~7 min windows/status-go 📦zip
52e0af6 #1 2025-12-12 22:23:05 ~11 min windows/nwaku 📄log
✔️ 52e0af6 #3 2025-12-12 23:04:49 ~25 min tests 📄log
✔️ 52e0af6 #2 2025-12-12 23:10:05 ~15 min tests-rpc 📄log
✔️ 52e0af6 #2 2025-12-12 23:26:20 ~11 min tests-rpc 📄log

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.50%. Comparing base (ea40003) to head (52e0af6).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7205       +/-   ##
============================================
+ Coverage    34.95%   59.50%   +24.55%     
============================================
  Files          807      820       +13     
  Lines       111424   113469     +2045     
============================================
+ Hits         38947    67524    +28577     
+ Misses       67560    39030    -28530     
- Partials      4917     6915     +1998     
Flag Coverage Δ
functional 34.92% <28.57%> (-0.04%) ⬇️
unit 54.81% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
accounts-management/persistence_operations.go 50.10% <ø> (ø)
accounts-management/types/keypair.go 65.88% <ø> (+16.47%) ⬆️
cmd/generate-db/main.go 0.00% <ø> (ø)
cmd/push-notification-server/main.go 51.66% <ø> (ø)
internal/abi-spec/utils.go 76.74% <ø> (ø)
internal/circuitbreaker/circuit_breaker.go 96.24% <ø> (ø)
internal/connection/state.go 92.00% <ø> (ø)
internal/db/appdatabase/database.go 72.95% <100.00%> (ø)
internal/db/appdatabase/migrations/migrate.go 100.00% <ø> (ø)
...al/db/appdatabase/migrationsprevnodecfg/migrate.go 100.00% <ø> (ø)
... and 18 more

... and 493 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants