Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

Iterates #7067

Description

  1. Moved images -> internal/images
  2. Refactored the way images are loaded in tests
    • Most tests now use gofakeit.ImagePng or gofakeit.ImageJpg
    • If real image is needed, it's loaded from testdata rather than from binary assets
  3. Killed _assets/tests
    • Some files moved to corresponding <package>/testdata where it's used
    • Some files deleted as unused
  4. Deleted now unused images/qr-assets.go

@status-im-auto
Copy link
Member

status-im-auto commented Dec 12, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2236bda #1 2025-12-12 22:24:36 ~4 min linux/status-go 📦zip
2236bda #1 2025-12-12 22:24:46 ~4 min macos/nwaku 📄log
✔️ 2236bda #1 2025-12-12 22:24:58 ~4 min macos/status-go 📦zip
✖️ 2236bda #1 2025-12-12 22:25:37 ~5 min tests 📄log
✖️ 2236bda #1 2025-12-12 22:25:58 ~5 min tests 📄log
✔️ 2236bda #1 2025-12-12 22:28:50 ~8 min linux/nwaku 📦zip
✔️ 2236bda #1 2025-12-12 22:29:16 ~8 min windows/status-go 📦zip
2236bda #1 2025-12-12 22:35:38 ~15 min windows/nwaku 📄log
✖️ 2236bda #1 2025-12-12 22:36:36 ~16 min tests-rpc 📄log
✖️ 2236bda #1 2025-12-12 22:38:08 ~17 min tests-rpc 📄log

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 2.85714% with 34 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (chore/project-layout-4-1@52e0af6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/testutils/images.go 0.00% 28 Missing ⚠️
protocol/persistence.go 0.00% 3 Missing ⚠️
server/handlers.go 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (2.85%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             chore/project-layout-4-1    #7206   +/-   ##
===========================================================
  Coverage                            ?   34.97%           
===========================================================
  Files                               ?      806           
  Lines                               ?   111217           
  Branches                            ?        0           
===========================================================
  Hits                                ?    38896           
  Misses                              ?    67456           
  Partials                            ?     4865           
Flag Coverage Δ
functional 34.97% <2.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/db/multiaccounts/database.go 64.85% <ø> (ø)
internal/images/adjust.go 0.00% <ø> (ø)
internal/images/color.go 0.00% <ø> (ø)
internal/images/decode.go 19.54% <ø> (ø)
internal/images/encode.go 29.72% <ø> (ø)
internal/images/identity.go 44.44% <ø> (ø)
internal/images/initials.go 0.00% <ø> (ø)
internal/images/main.go 36.25% <ø> (ø)
internal/images/manipulation.go 11.81% <ø> (ø)
internal/images/meta.go 0.00% <ø> (ø)
... and 34 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants