Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop constrain from wakuRequestResponse #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weboko
Copy link
Contributor

@weboko weboko commented Sep 19, 2024

This PR remove unnecessary constrain from wakuRequestResponse.
This is needed as some protocols or cases that we want to track do not have messageHash or peerId or unique pair of both and there might be no way of pushing unique data into the table.

@vpavlin
Copy link
Member

vpavlin commented Sep 23, 2024

@weboko Hey! You will need to make the change in a new migration file (20...) as once the migration happens, the version is set in DB and the migration scripts are not re-run again.

@vpavlin
Copy link
Member

vpavlin commented Sep 23, 2024

Also, don't forget to run make generate and attache changes to bindata.go as that is actually what golang migration library uses to execute the SQL migration queries:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants