Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add JavaScript implementation for iter/cartesian-power #2534

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add JavaScript implementation for iter/cartesian-power #2534

wants to merge 1 commit into from

Conversation

TheNourhan
Copy link
Contributor

@TheNourhan TheNourhan commented Jul 8, 2024 •
edited
Loading

Resolves #1336

Description

What is the purpose of this pull request?

This pull request:

  • Implementation of the iterCartesianPower function in the lib folder.
  • Documentation updates in the docs folder:
    • Added REPL usage examples to docs/repl.txt.
    • Created TypeScript type definitions in the docs/types folder.
  • Updated README.md.
  • Added benchmarks to the benchmark folder.
  • Added unit tests to the test folder.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@TheNourhan TheNourhan mentioned this pull request Jul 8, 2024
Closed
1 task
@kgryte kgryte added the Needs Review A pull request which needs code review. label Sep 21, 2024
@Planeshifter Planeshifter changed the title feat: add JavaScript implementation for iter/cartesian-power feat: add JavaScript implementation for iter/cartesian-power Sep 30, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Oct 1, 2024
@Planeshifter Planeshifter self-requested a review October 30, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/iter/cartesian-power
2 participants
@TheNourhan @kgryte