Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/dgemm #2541

Merged
merged 25 commits into from
Aug 15, 2024
Merged

feat: add blas/base/dgemm #2541

merged 25 commits into from
Aug 15, 2024

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jul 9, 2024 •
edited by aman-095
Loading

Progresses #2039.

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to perform one of the matrix-matrix operation C = α*op(A)*op(B) + β*C where op(A) is one of the op(A) = A, or op(A) = A^T, α and β are scalars, A, B, and C are matrices, with op(A) an M by K matrix, op(B) a K by N matrix and C an M by N matrix as defined in BLAS Level 3 routines. Specifically adding @stdlib/blas/base/dgemm is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

  • Add readme.md
  • Add package.json
  • Add lib
  • Add examples
  • Add ndarray implementation
  • Add docs
  • Add benchmark
  • Add test
  • Refactor implementation ( not sure if we can do this in here )

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 9, 2024
@Pranavchiku
Copy link
Member Author

I pushed the changes I had in my branch, I'll let @aman-095 work on this and finish this PR. Thank you!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Jul 14, 2024
@aman-095 aman-095 marked this pull request as ready for review August 13, 2024 13:36
@kgryte
Copy link
Member

kgryte commented Aug 15, 2024

@aman-095 Would you mind porting over the recent changes from #2742 to this PR? Thanks!

@aman-095 aman-095 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Aug 15, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 15, 2024
kgryte
kgryte approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku and @aman-095.

@kgryte kgryte merged commit a500a2a into stdlib-js:develop Aug 15, 2024
11 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@Pranavchiku @kgryte
@aman-095 @gunjjoshi
feat: add blas/base/dgemm
1583ae5 
PR-URL: stdlib-js#2541
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: Aman Bhansali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pranavchiku @kgryte @aman-095