fix: example command hanging in REPL when executing multi-line code
#2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <[email protected]>
kgryte
reviewed
Jul 29, 2024
Signed-off-by: Snehil Shah <[email protected]>
Planeshifter
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Looks fine and seems to work as expected. Thanks @Snehil-Shah!
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2706 Resolves: stdlib-js#2273 --------- Signed-off-by: Snehil Shah <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2273.
Description
This pull request:
examplecommand hanging with multiline code blocks. The command was waiting fordrainevents after every line, instead it should be waiting for events after every command blockRelated Issues
This pull request:
examplecommand hanging in REPL when executing multi-line code #2273Questions
No.
Other
The example code is also not syntactically highlighted. I will fix this in a separate PR.
Checklist
@stdlib-js/reviewers