feat: add LL_D in math/base/napi/binary
#2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Feature
kgryte
reviewed
Aug 1, 2024
lib/node_modules/@stdlib/math/base/napi/binary/include/stdlib/math/base/napi/binary.h
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
LGTM. Thanks, @gunjjoshi!
Would you mind submitting a follow-up PR fixing the missing includes in the int32 examples? Thanks!
@kgryte Sure, I'll make the PR. |
|
@gunjjoshi Looks like some of the README examples are also missing |
@kgryte I'll update them as well, thanks for the update. |
1 task
kgryte
added a commit
that referenced
this pull request
Aug 1, 2024
PR-URL: #2728 Ref: #2726 (review) Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
gunjjoshi
added a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2726 Ref: stdlib-js#2206 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
gunjjoshi
added a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2728 Ref: stdlib-js#2726 (review) Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
napi_value stdlib_math_base_napi_ll_d( napi_env env, napi_callback_info info, double (*fcn)( double, int64_t, int64_t ) )inmath/base/napi/binary.Related Issues
This pull request:
math/base/special/binomcoef#2206.Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers