Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for custom keybindings and editor actions in the REPL #2739

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat: add support for custom keybindings and editor actions in the REPL #2739

wants to merge 16 commits into from
+1,367 −3

Commits on Aug 3, 2024

  1. feat: add support for custom keybindings for editor actions 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    afcd816 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. fix: update EditorActions constructor

    @Snehil-Shah
    Snehil-Shah authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    8d5d407 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. fix: add support for parsing symbol based keybindings 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    ffd8d90 View commit details
    Browse the repository at this point in the history

  2. fix: allow one action per keybinding 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    6f270d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. fix: add prerequisite check 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9246a6f View commit details
    Browse the repository at this point in the history

  2. fix: only parse when needed 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2852f43 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. perf: use base package equivalents to bypass arg validations 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4561376 View commit details
    Browse the repository at this point in the history

  2. fix: allow cases where a keypress might trigger multiple actions 

    For instance, the right arrow key should also complete the completion.
It would be a better idea to clean up this logic in the PR where we add support for configuring keybindings for existing actions.

Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2fac8ab View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. fix: improve validator 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    629c44e View commit details
    Browse the repository at this point in the history

  2. fix: change order of actions for double actions 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    2ea1b2a View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Apply suggestions from code review 

    Signed-off-by: Athan <[email protected]>
    @kgryte
    kgryte authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dd32fea View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Signed-off-by: Athan <[email protected]>
    @kgryte
    kgryte authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5d21f07 View commit details
    Browse the repository at this point in the history

  3. fix: ignore initial whitespaces when modifying words 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5394596 View commit details
    Browse the repository at this point in the history

  4. docs: update types in jsdoc 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    163699d View commit details
    Browse the repository at this point in the history

  5. style: return null instead of boolean for consistent return types 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    17bce03 View commit details
    Browse the repository at this point in the history

  6. docs: fix incorrect jsdoc 

    Signed-off-by: Snehil Shah <[email protected]>
    @Snehil-Shah
    Snehil-Shah committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    849f37d View commit details
    Browse the repository at this point in the history