Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/max-base2-exponent #2748

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Aug 5, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (and matches @stdlib/constants/float64/max-base2-exponent aside from the exported value, of course.)

@Planeshifter Planeshifter merged commit 45d6f9d into stdlib-js:develop Aug 6, 2024
10 checks passed
@gunjjoshi gunjjoshi deleted the max-base2-exp branch August 7, 2024 05:15
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants