Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add array/base/cunone-by-right #2800

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat: add array/base/cunone-by-right #2800

merged 3 commits into from
Sep 16, 2024

Conversation

GittyHarsha
Copy link
Contributor

Resolves #2329

Description

What is the purpose of this pull request?

This pull request:

  • Adds implementation to @stdlib/array/base/cunone-by-right

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@GittyHarsha GittyHarsha marked this pull request as ready for review August 17, 2024 08:55
@GittyHarsha GittyHarsha changed the title feat: add @stdlib/array/base/cunone-by-right feat: add @stdlib/array/base/cunone-by-right Aug 17, 2024
@GittyHarsha GittyHarsha marked this pull request as draft August 17, 2024 09:49
@GittyHarsha GittyHarsha marked this pull request as ready for review August 17, 2024 09:53
@GittyHarsha GittyHarsha marked this pull request as draft August 17, 2024 09:55
@GittyHarsha GittyHarsha marked this pull request as ready for review August 17, 2024 10:08
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 2, 2024
@Planeshifter Planeshifter self-requested a review September 2, 2024 21:08
Planeshifter
Planeshifter requested changes Sep 7, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Left a bunch of comments, mostly documentation updates.

lib/node_modules/@stdlib/array/base/cunone-by-right/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/examples/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/test/test.assign.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/test/test.assign.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/lib/assign.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/lib/assign.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cunone-by-right/lib/assign.js Outdated Show resolved Hide resolved
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 7, 2024
@Planeshifter Planeshifter changed the title feat: add @stdlib/array/base/cunone-by-right feat: add array/base/cunone-by-right Sep 8, 2024
Planeshifter
Planeshifter approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will land shortly after landing some minor clean-up. Thanks again for your contribution, @GittyHarsha!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Sep 16, 2024
@Planeshifter Planeshifter merged commit e722c97 into stdlib-js:develop Sep 16, 2024
16 of 17 checks passed
@GittyHarsha
Copy link
Contributor Author

GittyHarsha commented Sep 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/cunone-by-right
2 participants
@GittyHarsha @Planeshifter