Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update JavaScript implementation and add C ndarray implementation for blas/base/isamax #2931

Merged
merged 11 commits into from
Oct 2, 2024
Merged

feat: update JavaScript implementation and add C ndarray implementation for blas/base/isamax #2931

merged 11 commits into from
Oct 2, 2024

Conversation

aman-095
Copy link
Member

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • updates the existing Js implementation to support negative strides.
  • adds C ndarray API

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 21, 2024
@aman-095 aman-095 marked this pull request as ready for review September 22, 2024 09:40
@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Sep 22, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Sep 24, 2024
kgryte
kgryte reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Just need to clean up the isamax_f.c file.

kgryte
kgryte approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte merged commit 206c660 into stdlib-js:develop Oct 2, 2024
10 checks passed
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @kgryte @stdlib-bot