Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use macros in addon and update examples in math/base/assert/is-evenf #3115

Merged
merged 2 commits into from
Nov 15, 2024
Merged

refactor: use macros in addon and update examples in math/base/assert/is-evenf #3115

merged 2 commits into from
Nov 15, 2024
+22 −70

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Nov 15, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • addresses suggestions from c664da7, for math/base/assert/is-evenf.
  • replaces the whole logic in addon.c by macros.
  • updates JS examples.
  • adds missing C headers.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 15, 2024
kgryte
kgryte approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte changed the title refactor: use macros in addon, update examples in math/base/assert/is-evenf refactor: use macros in addon and update examples in math/base/assert/is-evenf Nov 15, 2024
@kgryte kgryte merged commit 15dff30 into stdlib-js:develop Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @kgryte @stdlib-bot