Support es-module default exports in babel plugins #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallswain
force-pushed
the
handle-plugin-esmodules
branch
from
c8baaf1 to
6ada067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for babel plugins that use ES modules that use the default export. The problem was that somewhere in this plugins array the module paths were being replaced by the
required modules. An ES module would become replaced by{ isEsModule: true, default: Fn }, which wouldn't pass theisPluginFunction(plugin)conditional on subsequent calls to processPlugins.The 3-line change in this PR just check for the presence of
pluginFn.defaultand use that aspluginFn.