Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial training procedure #46

Merged
merged 22 commits into from
Nov 5, 2024
Merged

Initial training procedure #46

merged 22 commits into from
Nov 5, 2024

Conversation

stefanDeveloper
Copy link
Owner

For the first release, we want to support RandomForest, and XGBoost.

@stefanDeveloper stefanDeveloper added this to the First heiDGAF version milestone Oct 14, 2024
@stefanDeveloper stefanDeveloper self-assigned this Oct 14, 2024
@stefanDeveloper stefanDeveloper linked an issue Oct 14, 2024 that may be closed by this pull request
@stefanDeveloper stefanDeveloper marked this pull request as draft October 14, 2024 08:45
Copy link

github-actions bot commented Oct 14, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1257 1179 94% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/_init_.py 100% 🟢
src/base/kafka_handler.py 62% 🟢
src/detector/detector.py 99% 🟢
src/inspector/inspector.py 98% 🟢
TOTAL 90% 🟢

updated for commit: b49ebcb by action🐍

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (b285b1f) to head (1ca63a2).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/base/kafka_handler.py 28.57% 5 Missing ⚠️
src/inspector/inspector.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   90.30%   93.15%   +2.85%     
==========================================
  Files          11       11              
  Lines        1176     1257      +81     
  Branches      150      126      -24     
==========================================
+ Hits         1062     1171     +109     
+ Misses        106       78      -28     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanDeveloper
Copy link
Owner Author

@lamr02n Please note that the test of the detector is under implementation. Meanwhile please review the remaining code so far.

@stefanDeveloper stefanDeveloper marked this pull request as ready for review October 21, 2024 10:55
@stefanDeveloper stefanDeveloper added the enhancement New feature or request label Oct 21, 2024
Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docker/docker-compose.external.yml Outdated Show resolved Hide resolved
src/train/dataset.py Show resolved Hide resolved
Copy link
Collaborator

@lamr02n lamr02n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanDeveloper stefanDeveloper merged commit 8af7903 into main Nov 5, 2024
15 checks passed
@stefanDeveloper stefanDeveloper deleted the train-models branch November 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add detector implementation
2 participants