Skip to content

Update missing docstrings or docstrings with too few information#74

Merged
stefanDeveloper merged 2 commits intomainfrom
documentation/add-docstrings
Apr 22, 2025
Merged

Update missing docstrings or docstrings with too few information#74
stefanDeveloper merged 2 commits intomainfrom
documentation/add-docstrings

Conversation

@maldwg
Copy link
Collaborator

@maldwg maldwg commented Apr 22, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 22, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1437 1428 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/base/clickhouse_kafka_sender.py 100% 🟢
src/base/data_classes/batch.py 100% 🟢
src/base/kafka_handler.py 100% 🟢
src/detector/detector.py 99% 🟢
src/inspector/inspector.py 98% 🟢
src/logcollector/batch_handler.py 100% 🟢
src/monitoring/clickhouse_batch_sender.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 3dc130c by action🐍

@stefanDeveloper stefanDeveloper self-requested a review April 22, 2025 10:41
@stefanDeveloper stefanDeveloper added the documentation Improvements or additions to documentation label Apr 22, 2025
Copy link
Owner

@stefanDeveloper stefanDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@stefanDeveloper
Copy link
Owner

Check pipeline, currently precommit is failing

@maldwg
Copy link
Collaborator Author

maldwg commented Apr 22, 2025

How is that possible, i was only adding docstrings....

@stefanDeveloper
Copy link
Owner

I guess we can merge it anyway since it is only docstrings, just double-check pre-commit

@maldwg
Copy link
Collaborator Author

maldwg commented Apr 22, 2025

So the precommit hook is running thorugh but test coverage is complaining now ?
FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/heiDGAF/heiDGAF/assets/coverage_documentation/add-docstrings.svg'

Seems a little weird to me

@stefanDeveloper stefanDeveloper merged commit 5df4172 into main Apr 22, 2025
15 of 16 checks passed
@stefanDeveloper stefanDeveloper deleted the documentation/add-docstrings branch April 22, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants