Skip to content

Remove LogCollector Fill Level panels from dashboard#91

Merged
stefanDeveloper merged 5 commits intov1.0.0-rc1from
90-log-volume-collector-fill-state-not-updating
Sep 29, 2025
Merged

Remove LogCollector Fill Level panels from dashboard#91
stefanDeveloper merged 5 commits intov1.0.0-rc1from
90-log-volume-collector-fill-state-not-updating

Conversation

@lamr02n
Copy link
Collaborator

@lamr02n lamr02n commented Sep 29, 2025

Issue #90 described that the LogCollector does not provide its fill level to Grafana. The reason for this is that after refactoring the LogCollector in response to performance issues, it no longer has an internal data structure and therefore no fill level. The fill level of this module is therefore at most 1, which renders fill level information irrelevant.

This PR removes the respective panels of the LogCollector fill level and updates those that also show its fill level. There have also been small and non-functional adjustments to some of the other panels.

Resolves #90.

@lamr02n lamr02n self-assigned this Sep 29, 2025
@lamr02n lamr02n linked an issue Sep 29, 2025 that may be closed by this pull request
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1455 1446 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/logcollector/collector.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 24086fd by action🐍

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.90%. Comparing base (f6462cb) to head (24086fd).
⚠️ Report is 8 commits behind head on v1.0.0-rc1.

Additional details and impacted files
@@              Coverage Diff               @@
##           v1.0.0-rc1      #91      +/-   ##
==============================================
- Coverage       98.90%   98.90%   -0.01%     
==============================================
  Files              15       15              
  Lines            1457     1455       -2     
  Branches          155      155              
==============================================
- Hits             1441     1439       -2     
  Misses              9        9              
  Partials            7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanDeveloper stefanDeveloper changed the base branch from main to v1.0.0-rc1 September 29, 2025 07:56
@stefanDeveloper
Copy link
Owner

All changes should be merged into v1.0.0-rc1

Copy link
Owner

@stefanDeveloper stefanDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side!

@stefanDeveloper stefanDeveloper merged commit b558c43 into v1.0.0-rc1 Sep 29, 2025
19 checks passed
@stefanDeveloper stefanDeveloper deleted the 90-log-volume-collector-fill-state-not-updating branch September 29, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log Volume Collector Fill State not updating

2 participants