Correctly parse Attributes with multiple AttributeValues as arrays of strings #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffow
reviewed
Feb 16, 2018
| if (Meteor.settings.debug) { | ||
| console.log("Name: " + attributes[i]); | ||
| console.log(`Adding attrinute from SAML response to profile:` + attributes[i].getAttribute('Name') + " = " + value.textContent); | ||
| console.log(`Adding attribute from SAML response to profile:` + attributes[i].getAttribute('Name') + " = " + value); | ||
| } |
There was a problem hiding this comment.
Any reason why you're using 'value' vs 'value.textContent'?
There was a problem hiding this comment.
In the case of multiple attribute values, where "value" is an array, "value.textContent" will be undefined. Logging "value" should work whether it is a string or an array.
# Conflicts: # saml_utils.js
|
It may be simpler to keep your manual update and discard the PR :-) |
|
@steffow thanks for this package. to: |
|
Hey atao60 - thanks for bringing this up. I would need to look at this, but IIIRC I changed this because it made one of my test fail.
Do you have an example to see the difference?
S.
… On 13. Jan 2019, at 09:16, atao60 ***@***.***> wrote:
@steffow thanks for this package.
It seems to me that not all the changes of PR #27 have been made in the current code (v0.0.17).
Then it's not working as it.
I had to change the lines 464 and 466 (v0.0.17) from:
console.log(`Adding attrinute from SAML response to profile:` + attributes[i].getAttribute('Name') + " = " + value.textContent);
profile[attributes[i].getAttribute('Name')] = value.textContent;
to:
console.log(`Adding attribute from SAML response to profile:` + attributes[i].getAttribute('Name') + " = " + value);
profile[attributes[i].getAttribute('Name')] = value;
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@steffow what do you need? Some code in a github repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented fix for #26
If one AttributeValue exists, it is returned as a string (as per current behaviour).
If more than one AttributeValue exists, they are returned as an array of strings.