Fix trust token persistence race condition #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trustToken getter re-reads the file and overwrites the in-memory value every time it's accessed. This causes a race condition where: 1. applyTrustResponse() sets the trust token and starts writing to file 2. The TRUSTED event accesses trustToken via getter, re-reading the file 3. The getter overwrites the in-memory value with undefined (old file value) 4. The file write completes, but writes undefined (which gets omitted from JSON) Fix by using _resources.trustToken directly in the two places where we emit TRUSTED events immediately after setting the token, avoiding the getter's file re-read that would overwrite the newly set value. Fixes issue where MFA is required on every run because trust token isn't persisted to the resource file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #931
The
trustTokengetter re-reads the file and overwrites the in-memory value, causing a race condition where the token is cleared before it's persisted.Use
_resources.trustTokendirectly when emitting TRUSTED events to avoid the getter's file re-read.