-
Notifications
You must be signed in to change notification settings - Fork 219
Add /ready endpoint for comprehensive service readiness checking #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: sagpatil <[email protected]>
…ealth Co-authored-by: sagpatil <[email protected]>
Co-authored-by: sagpatil <[email protected]>
Co-authored-by: sagpatil <[email protected]>
Can the endpoint be |
It's fine for the /health endpoint to sit over Horizon's health endpoint. |
@copilot can you rename the endpoint to /health |
Co-authored-by: sagpatil <[email protected]>
Co-authored-by: sagpatil <[email protected]>
Co-authored-by: sagpatil <[email protected]>
@sagpatil @fnando There was a discussion offline at https://stellarfoundation.slack.com/archives/C06KTGUULUF/p1752530679018619 where I shared the idea that we think about the root URL as the health endpoint. For the most part that's what it is for horizon historically, and as a user it's where I go when I want to see that the image is working. When Horizon is removed from being by default on, we should rethink the root path and what it serves, and a status / health like endpoint, like what horizon does today, could make sense. |
This PR adds a new
/ready
endpoint that provides a simple way to determine when the Stellar Quickstart image is fully ready for use, addressing the issue where users need to write custom scripts to test readiness.Changes
New
/ready
EndpointExample response when ready:
Implementation Details
/info
endpoint/health
getHealth
JSON-RPC method/health
endpointArchitecture
/ready
through main port 8000Documentation
/health
(Horizon-specific) and/ready
(all services)Testing
Verified working with test container running
--local --enable core,horizon,rpc
:/health
endpoint continues to workThis eliminates the need for users to write custom scripts to test multiple service endpoints individually.
Fixes #683.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.