Make lab smaller #706
Merged
Make lab smaller #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is amazing! Thanks for taking a look. |
fnando
approved these changes
Jul 11, 2025
|
This is great! The size came down lot, thank you @leighmcculloch! cc @sagpatil |
|
Awesomeness 😎 this is amazing thanks @leighmcculloch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reduce the lab files embedded into the image to only the files needed to run lab.
Before lab
Uncompressed: 0.70G
Compressed: 0.23G
https://hub.docker.com/layers/stellar/quickstart/v481-future/images/sha256-7480e1b3f568ee4848bb907854266de13e04e83a8610b6bdafa5ed5bf6495d33
After lab, Before this PR
Uncompressed: 2.33G
Compressed: 0.60G
https://hub.docker.com/layers/stellar/quickstart/v484-future/images/sha256-0528af8c7585d32533bc0ba2b33772f18c4809f27d0183e0cd40f48399e8897c
After this PR
Uncompressed: 0.91G
Compressed: 0.29G
https://hub.docker.com/layers/stellar/quickstart/pr706-v485-future/images/sha256-75cd5dc2f3a8c6e22765fdfdeb4f9ef4929ca90c7b9ad3eb1eed6c97550ec153
Why
Quickstart got bigger when we added lab. We followed the instructions in the lab repo for how to use the production build, but it turns out lab actually builds a standalone version of Next.js that is smaller in size and can be used instead.
Close #695
Related: