Skip to content

Commit

Permalink
Const error message POSSIBLY_CORRUPTED_HISTORY, add more guidance
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasBrady committed Oct 23, 2024
1 parent 07d1284 commit 9c30d74
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
13 changes: 4 additions & 9 deletions src/historywork/CheckSingleLedgerHeaderWork.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "history/HistoryArchive.h"
#include "history/HistoryManager.h"
#include "historywork/GetAndUnzipRemoteFileWork.h"
#include "main/ErrorMessages.h"
#include "util/GlobalChecks.h"
#include "util/Logging.h"
#include "util/TmpDir.h"
Expand Down Expand Up @@ -86,15 +87,9 @@ CheckSingleLedgerHeaderWork::doWork()
{
CLOG_ERROR(
History,
"Failed to download ledger checkpoint {} from archive {}. This may "
"be due to transient network issues, or the archive may be missing "
"the checkpoint. stellar-core will try to download the file from "
"another archive. This error *does not* necessarily require a "
"configuration change to remove the archive, but please ensure you "
"have the correct archive for the operator in your configuration "
"file. If you repeatedly see this error, please notify the "
"operator of the archive that you are observing gaps.",
mFt->baseName_gz(), mArchive->getName());
"Failed to download ledger checkpoint {} from archive {}: {}",
mFt->baseName_gz(), mArchive->getName(),
POSSIBLY_CORRUPTED_HISTORY);
return mGetLedgerFileWork->getState();
}

Expand Down
7 changes: 6 additions & 1 deletion src/main/ErrorMessages.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ constexpr auto const REPORT_INTERNAL_BUG =
"Please report this bug along with this log file if this was not expected";
constexpr auto const POSSIBLY_CORRUPTED_HISTORY =
"One or more of history archives may be corrupted. Update HISTORY "
"configuration entry to only contain valid ones";
"configuration entry to only contain valid ones. If you have a valid "
"HISTORY configuration entry for the archive and repeatedly see this "
"error, please notify the operator of the archive that you are observing "
"gaps. Avoid removing the validator from your quorum set unless you have "
"coordinated with other operators and carefully considered the impact of "
"doing so.";
constexpr auto const POSSIBLY_CORRUPTED_LOCAL_FS =
"There may be a problem with the local filesystem. Ensure that there is "
"enough space to perform that operation and that disc is behaving "
Expand Down

0 comments on commit 9c30d74

Please sign in to comment.