Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Archive merge into Cold Archive #4530

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

SirTyson
Copy link
Contributor

Description

Partially resolves #4396

When the HotArchive BucketList becomes full, it needs to be merged into a single ColdArchive Bucket. This bucket will be used to initialize the ColdArchive BucketList that produces the root merkle hash for the given archival trie.

This PR adds functionality to merge a completed HotArchive into a single ColdArchive Bucket. For simplicty, this is not done using the FutureBucket interface. Due to this, we can not pick up in-progress merges across node restarts. If a merge is not completed and the node restarts, the node will have to restart the merge. However, if a node finishes the merge then restarts, it will pick up the finished bucket on restart. I think for now this is fine. The HotArchive BucketList will be small such that merges are quick. If this is an issue, it can always be addressed later.

Opening as a draft until #4403 is merged.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create lazily instantiated Merkle Tree implementation on top of BucketListDB
1 participant